This repository has been archived by the owner on May 6, 2022. It is now read-only.
Bump bundler version for jekyll and set fix version for jekyll #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/test pull-service-catalog-test-integration |
1 similar comment
|
/test pull-service-catalog-test-integration |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MHBauer, mszostok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
lol |
MHBauer
approved these changes
May 8, 2020
mszostok
added a commit
to mszostok/service-catalog
that referenced
this pull request
May 18, 2020
mszostok
added a commit
that referenced
this pull request
May 18, 2020
This was referenced May 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem desc
Currently, our pipelines are failing at
make docsstep, see: https://travis-ci.org/github/kubernetes-sigs/service-catalog/jobs/684782097.The reason is that we are using
jekyll/jekyllwith the latest tag and in the newer version thebundlerwas updated to 2.1.4.Updating builder to
2.1.4failed on netlify.com: https://app.netlify.com/sites/svc-cat/deploys/5eb5a7188c79b800070db33fUnfortunately, I do not have access to
Paul Morie's team/svc-catso I just selected the2.0.1as a fixed version.Changes proposed in this PR:
gemfile.lockwith bundler version2.0.1which satisfy the newest Jekyll and netlify.comjekyll/jekylltojekyll/jekyll:4.0, so the fixed version is used instead of thelatesttag (4.0 is the latest release)Steps used to fix: